Skip to content

Merge ReBACH-Bagger #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 142 commits into from
Dec 21, 2022
Merged

Merge ReBACH-Bagger #13

merged 142 commits into from
Dec 21, 2022

Conversation

jonathannoah
Copy link
Contributor

This commit adds the ReBACH-Bagger tool to the ReBACH repo (Issue #12).

jonathannoah and others added 30 commits September 23, 2022 16:41
@jonathannoah
first commit
264da24
@jonathannoah
Add test files and notebook
da29d59
@jonathannoah
Make dart-runner command configurable and relative to __file__ path
a570f9f
@jonathannoah
Reorganization, add config files
6e7dd41
@jonathannoah
Update notebook and gitignore for new workflow config
279ae10
@jonathannoah
Cleanup and remove test workbook.
0a8fc47
@jonathannoah
Create main.py and setup basic program logic.
758a51d
@jonathannoah
Code cleanup
d241f3c
@jonathannoah
Update requirements.txt
2788fd5
@jonathannoah
Add defaults to default.ini
f6afb0e
@jonathannoah
Integrate config options with command line overrides, add docstrings
2ae5f82
@jonathannoah
Update .idea files
f355d29
@jonathannoah
Change version numbering
2db01d6
@jonathannoah
Add config/default_workflow.json
28f8e6b
@jonathannoah
Add TODO.md
b7f92a9
@jonathannoah
Update .idea files
93c07c4
@jonathannoah
Update README.md
b83482e
@jonathannoah
Remove job_params.json.
1364b31
@jonathannoah
Update .gitignore to ignore dart-runner executable.
0dd96b6
@jonathannoah
Remove dart-runner.
f74e758
@jonathannoah
Add .flake8 linting configuration
73ecb7a
@jonathannoah
Change long single-line command variable definition
7ce80bb
@jonathannoah
Linting, code reformat
a782beb
@jonathannoah
Fix spacing of DART command definition
ca1fcd4
@jonathannoah
Update .gitignore
56fddcb
@jonathannoah
Move get_args() to __init__.py under config/ directory.
4f0e76a
@jonathannoah
Add __version__ variable to top __init__.py
6df6b31
@jonathannoah
Change name of login and password to access_key and secret_key
ba03614
@jonathannoah
Rename param package_name to bag_name
45c1afe
@jonathannoah
Update run method to return output data instead of printing
0cd1d3e
zoidy and others added 15 commits December 13, 2022 10:41
@zoidy @jonathannoah
Add GH action for linting using flake8
88be139
@zoidy @jonathannoah
Add bug report template
651dc12
@zoidy @jonathannoah
Change the regexes to be more flexible on article_id and version
a6bb859
@zoidy @jonathannoah
make curation validation less strict
196a105 
See #8
@zoidy @jonathannoah
Fix linting errors
e261f61
@zoidy @jonathannoah
Remove complexity check from linter
efd4712
@jonathannoah
Merge remote-tracking branch 'origin/12-merge-rebach-bagger' into 12-…
f35669d 
…merge-rebach-bagger
@jonathannoah
Update .gitignore files
f364da9
@jonathannoah
Update documentation, example config
e1f76d2
@jonathannoah
Add HTML stripping, shortening to metadata
01f0aff
@jonathannoah
Update tests, add test data
fd5c4d5
@jonathannoah
Add dry-run functionality via decorator
a267e6c
@jonathannoah
Use string for metadata value by default
8b972c0 
Allows for the option to use a string literal as the value for a metadata mapping. Metadata parser will also now correctly parse a tag_path with lists and indices.
@jonathannoah
Update workflow files and tests
f4400eb 
Also upload a copy of the ReBACH BagIt profile.
@jonathannoah
Improve dry-run implementation
b2fa744
jonathannoah
jonathannoah commented Dec 16, 2022
View reviewed changes
Copy link
Contributor Author

@jonathannoah jonathannoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates include dry-run mode, HTML stripping, final workflow and profile files, improved metadata configuration, and additional documentation.

zoidy
zoidy previously approved these changes Dec 16, 2022
View reviewed changes
@zoidy zoidy requested review from jcoliver and yhan818 December 16, 2022 15:45
jcoliver
jcoliver reviewed Dec 20, 2022
View reviewed changes
jcoliver
jcoliver reviewed Dec 20, 2022
View reviewed changes
Copy link

@jcoliver jcoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments added inline to README.md

yhan818
yhan818 reviewed Dec 20, 2022
View reviewed changes
yhan818
yhan818 reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@yhan818 yhan818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments

@zoidy
Copy link
Collaborator

zoidy commented Dec 21, 2022

Closes #12

@zoidy zoidy merged commit 21c30f0 into main Dec 21, 2022
@zoidy zoidy deleted the 12-merge-rebach-bagger branch December 21, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoliver jcoliver jcoliver left review comments

@yhan818 yhan818 yhan818 left review comments

@zoidy zoidy zoidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathannoah @zoidy @jcoliver @yhan818 @astrochun