Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: make curation validation less strict #10

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

zoidy
Copy link
Collaborator

@zoidy zoidy commented Oct 4, 2022

Description

Change the json schema to allow more flexibility in the curation packages. Allows more missing files that aren't relevant for preservation, more flexibility in naming of required files

Fixes #8

Testing (if applicable)

Run directory-validate.py on the testing data with the ualrdm-curationdirectory-schema.json schema

Copy link
Contributor

@yhan818 yhan818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line 120 "^Deposit.Agreement" old file name "^Deposit_Agreement" seems better.

@zoidy
Copy link
Collaborator Author

zoidy commented Oct 4, 2022

Not to worry, L120 is a regular expression. "." means any character

@yhan818 yhan818 closed this Oct 4, 2022
@zoidy zoidy reopened this Nov 10, 2022
@zoidy zoidy merged commit 9b2eec4 into main Nov 10, 2022
@zoidy zoidy deleted the bug/8_curation_schema_validation branch November 10, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: curation schema is too strict
2 participants