Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CancellationToken support and tests #27

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Added CancellationToken support and tests #27

merged 2 commits into from
Jul 23, 2020

Conversation

AlexRadch
Copy link
Contributor

Turnerj
Turnerj reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@Turnerj Turnerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good - I've added a few comments inline. 🙂

@Turnerj Turnerj merged commit 8837155 into TurnerSoftware:master Jul 23, 2020
@Turnerj
Copy link
Member

Turnerj commented Jul 23, 2020

Thanks for your work! 🙂

@AlexRadch AlexRadch deleted the CancellationTokenSupport branch July 28, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turnerj Turnerj Turnerj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexRadch @Turnerj