-
Notifications
You must be signed in to change notification settings - Fork 26
Add connection timeout #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For clearer control over connection timeouts.
At the request of clippy
077110c
to
d1b30d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want some safe defaults here? If I specify just a timeout but no connect_timeout, should the connect_timeout be assumed to be the same as timeout?
Co-authored-by: Conrad Ludgate <oon@conradludgate.com>
I like this idea. Done. |
I apparently don't have write access to merge 🥺 |
Adds a
connect_timeout()
option toLoadBalancedChannelBuilder
.Relevant to #37.
Note: hyperium/tonic#1215 will need merging first for this to work.