Allow specifying additional extensions to ESLint

[Tomtomgo]

ESLint can be used for not just JS files, it can also be used for
TypeScript files. Currently Sputnik does not consider any other file
extension than .js for ESLint linting.

To make Sputnik pass TypeScript files to ESLint, we add an option to
consider additional file types: eslint.additionalExtensions. It expects
a comma-joined string of extensions, without "." in front. For example
"ts,tsx".

This configuration is injected into the ESLintProcessor from the
ESLintProcessorFactory. While we're at it, we also pull out
construction of the ESLintExecutor to ESLintProcessorFactory.

Closes #213.

[codecov-io]

Codecov Report

Merging #214 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
- Coverage     73.52%   73.45%   -0.08%     
  Complexity      612      612              
============================================
  Files           145      146       +1     
  Lines          1953     1955       +2     
  Branches        127      127              
============================================
  Hits           1436     1436              
- Misses          460      462       +2     
  Partials         57       57

Impacted Files	Coverage Δ	Complexity Δ
...utnik/processor/eslint/ESLintProcessorFactory.java	66.66% <ø> (ø)	2 <0> (ø)	⬇️
...va/pl/touk/sputnik/review/filter/ESLintFilter.java	0% <0%> (ø)	0 <0> (?)
...touk/sputnik/processor/eslint/ESLintProcessor.java	0% <0%> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd6622...334a847. Read the comment docs.

[SpOOnman]

I like the idea of including more extensions for ESLint. Thanks!

Your implementation lacks tests and you modify JavaScriptFilter with empty array, which is used elsewhere. That should be fixed.

Although I think that you can simplify your implementation. If ESLint supports js, jsx, ts and tsx file just create ESLintFilter especially for it? Just take a look at PmdFilter. It would be trivial and it would cover all your needs I guess?

[Tomtomgo]

Thanks for the comments @SpOOnman!

Your implementation lacks tests and you modify JavaScriptFilter with empty array, which is used elsewhere. That should be fixed.

Does this still hold given we add ESLintFilter now? I wasn't able to spot existing tests to change/update.

Although I think that you can simplify your implementation. If ESLint supports js, jsx, ts and tsx file just create ESLintFilter especially for it? Just take a look at PmdFilter. It would be trivial and it would cover all your needs I guess?

Good call, what about the updated commit?

[SpOOnman]

Thanks @Tomtomgo !