-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide support for ShowMode in SwitchTo and Cancel widgets #350 #354
Conversation
should we use ShowMode.AUTO for default or make it Optional? |
@@ -117,6 +121,7 @@ def __init__( | |||
result: Any = None, | |||
on_click: Optional[OnClick] = None, | |||
when: WhenCondition = None, | |||
show_mode: ShowMode = ShowMode.AUTO, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do it in the same way as in manager methods:
show_mode: Optional[ShowMode] = None,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -8,6 +8,8 @@ | |||
from aiogram_dialog.widgets.common import WhenCondition | |||
from aiogram_dialog.widgets.text import Const, Text | |||
from aiogram_dialog.widgets.widget_event import WidgetEventProcessor | |||
from aiogram_dialog import ShowMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's have full imports from api package like above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Close issue #350, now users can pass show_mode argument to Cancel and SwitchTo widgets