Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fork #22

Closed
wants to merge 4 commits into from
Closed

Update fork #22

wants to merge 4 commits into from

Conversation

TillRasmussen
Copy link
Owner

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    ENTER INFORMATION HERE
  • Developer(s):
    ENTER INFORMATION HERE
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

apcraig and others added 4 commits September 27, 2024 10:42
@apcraig
Update Derecho Port (#974)
6428405 
Update derecho port

    update inteloneapi, validate, use -O1, problems with -check all.
    update cray to ncarenv/23.09 and cce/16.0.1, answers change
    update intel to ncarenv/23.09 and intel/2023.2.1, answer bit-for-bit
    update nvhpc to ncarenv/23.09 and nvhpc/23.7, answers change
    update queue so smaller jobs go into develop (shared) instead of main

Add ifndef __INTEL_LLVM_COMPILER (for intel oneapi) around an OMP loop that the compiler doesn't handle properly (reported to intel) in ice_history.F90.

Update QC documentation in the user guide to clarify where/how to run the cice.t-test.py script.
@NickSzapiro-NOAA
Update call to icepack_aggregate in ice_prescribed_mod.F90 (#980)
68b2610 
Was missed as part of the BGC + Icepack interface update.
@dabail10 @jedwards4b
These reduce some of the prints in shr_orbital. (#981)
87c7bfa 
* reduce orbital parameters output to log

* avoid printing in initialization as ice log is not yet ready

---------

Co-authored-by: Jim Edwards <jedwards@ucar.edu>
@dabail10 @jedwards4b @anton-seaice
This adds additional write restart at end of run functionality. (#984)
7a4eb51 
* support for cesm write_restart_at_endofrun

* clean up merge

* correct rpointer file name for cesm

* response to review

* correct exist and file_exist

* get pointer file name root from ice_in namelist and append timestamp for cesm

* Update cicecore/cicedyn/infrastructure/io/io_pio2/ice_restart.F90

Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>

* the pointer_file name is set in namelist, no need to modify here

* cleanup whitespace

* need to use default cesm pointer name for write and not read from ice_in namelist

---------

Co-authored-by: Jim Edwards <jedwards@ucar.edu>
Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TillRasmussen @apcraig @NickSzapiro-NOAA @dabail10