Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem: Include macOS in BSD defines #137

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

jcm93
Copy link
Contributor

@jcm93 jcm93 commented Sep 2, 2024

Context: Building slangmosh for paraLLEl-RDP standalone builds on macOS requires the filesystem target. Was not building because of BSD-style filesystem definitions.

Also add a define for off64_t which I don't think exists on BSD. I don't have a BSD system to test on, but using off_t was required for macOS as well.

@jcm93
Copy link
Contributor Author

jcm93 commented Sep 2, 2024

@bsdcode Any idea about off_t vs off64_t here?

@bsdcode
Copy link
Contributor

bsdcode commented Sep 3, 2024

That's ok. On FreeBSD, both off_t and off64_t are defined and resolve to the same underlying type. Compilation with your change is successful here on FreeBSD.

@jcm93 jcm93 changed the title filesystem: Fix defines for BSD, add defines for macOS filesystem: Include macOS in BSD defines Sep 4, 2024
@Themaister Themaister merged commit a75f206 into Themaister:master Sep 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants