Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Bubble Sort in Commodore Basic #3736

Merged

Conversation

rzuckerm
Copy link
Collaborator

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

Other Notes

I am the original author, and I realized that I had implemented the algorithm incorrectly. I found that input like "1, 2, 4, 3" would remain unsorted.

@rzuckerm rzuckerm added enhancement Any code that improves the repo bubble sort See: https://sampleprograms.io/projects/bubble-sort/ labels Jan 22, 2024
@rzuckerm rzuckerm marked this pull request as ready for review January 22, 2024 16:13
@jrg94 jrg94 requested a review from a team January 22, 2024 17:49
@jrg94 jrg94 self-assigned this Jan 22, 2024
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not knowledgeable enough to understand exactly what this improves, but it looks cleaner.

@jrg94 jrg94 merged commit d75e24b into TheRenegadeCoder:main Jan 22, 2024
6 checks passed
@jrg94
Copy link
Member

jrg94 commented Jan 22, 2024

Oh just saw your note! Okay, I see the issue now.

@rzuckerm rzuckerm deleted the modify-bubble-sort-commodore-basic branch January 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bubble sort See: https://sampleprograms.io/projects/bubble-sort/ enhancement Any code that improves the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Bubble Sort in Commodore Basic
2 participants