Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hello World in Gosu #2316

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Add Hello World in Gosu #2316

merged 2 commits into from
Nov 3, 2020

Conversation

prakharpande
Copy link
Contributor

@prakharpande prakharpande commented Oct 24, 2020

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Adding a New Code Snippet in an Existing Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding a New Code Snippet in a New Language

  • I fixed Add Hello World in Gosu #196
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I created/updated the language README (see contributing documentation)
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see plagiarism)

I Am Adding New Tests for a Project

  • I fixed #your-issue-number-here
  • I named the pull request using Add {PROJECT} tests format
  • I verified the project exists on the Sample Programs Project List
  • I added tests for every test case in the Testing table of the project description for the given project. (See contributing documentation)

I Am Adding New Tests for a Language

  • I fixed #your-issue-number-here
  • I named the pull request using Add {LANGUAGE} tests format\
  • I added a testinfo.yml files (see [contributing documentation][contributing-new-language])
    • I used an officially supported docker image or one that I personally trust
  • I verified all tests are passing

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed #your-issue-number-here
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

Add notes here...

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Do you happen to know if this language has a Docker image? Ideally, we'd want to get this new language tested.

@jrg94 jrg94 self-assigned this Oct 27, 2020
@jrg94 jrg94 added enhancement Any code that improves the repo hello world See: https://sampleprograms.io/projects/hello-world/ labels Oct 27, 2020
@jrg94 jrg94 added this to the 1,000 Code Snippets milestone Oct 27, 2020
@jrg94
Copy link
Member

jrg94 commented Nov 3, 2020

This might be the image... https://hub.docker.com/r/gosu/alpine

Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this for now. I'll address the testing issue when I get around to cleaning things up.

@jrg94 jrg94 merged commit 27b6745 into TheRenegadeCoder:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo hello world See: https://sampleprograms.io/projects/hello-world/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Hello World in Gosu
2 participants