-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Factorial in SCALA #2099
Added Factorial in SCALA #2099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just make sure the program pulls from the command line.
Hey @jrg94, thanks for suggesting changes. I am new to scala. If you can just tell me what do I do to make sure the program gets merged, it'll be really great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope this helps!
Hey @jrg94, I have updated the code. Please go through it and let me know if you want any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better! We may revisit this when we do some testing. There are deprecation warnings, and the formatting is a bit messy.
Hey @jrg94, If you can add the hacktoberfest-accepted label to this pull request, it'll be really great. |
Do you have any documentation on that label? I haven't seen anything about it on the official site. |
Nevermind, I saw this: https://hacktoberfest.digitalocean.com/hacktoberfest-update |
It's sort of a pain to label all accepted pull requests. Based on the article above, merging and accepting should be enough. |
okay no worries. thanks for letting me know. I have another pull request
for a Non repeating character In CPP. Please take a look into that.
…On Mon, Oct 5, 2020 at 9:03 PM Jeremy Grifski ***@***.***> wrote:
It's sort of a pain to label all accepted pull requests. Based on the
article above, merging and accepting should be enough.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2099 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANMVHQVAOZDOFP6HF6KJZ6TSJHRMLANCNFSM4SDEWWDA>
.
|
Hey @uditpatel2526! If you enjoyed contributing to this project and would like to make sure that it continues to be maintained, we can always use your support at The Renegade Coder. Here are some ways you can help out:
Thanks for your help! |
Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.
Complete the Applicable Sections Below
Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.
Code Snippets
Added/Updated <Sample Program> in <Language>
formatTesting
Added/Updated <Language>/<Project> Testing
formatNotes
Feel free to describe what you added or updated.