-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment.md #27093
Update deployment.md #27093
Conversation
removed the aforementioned link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine. passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the link for the video.
@kamranzafar4343 are you going to put the link back in? If not, I'm going to have to close this PR. |
Why to put link back in? |
You removed a link in the lesson for "GoNodeJS video guide for deploying NodeJS applications to Fly.io". Why did you do that? |
"Remove aforementioned link from the Node path's deployment lesson" |
You wrote that in the PR description. Why is it being removed? The issue you linked has to do with markdown styling. I'm very confused why this link is being removed from the lesson. Is there a different issue I should be looking at? |
This comment was marked as off-topic.
This comment was marked as off-topic.
I think the probelm is caused by linking a different issue with PR. |
@fortypercenttitanium the issue was solved by linking the relevant issue with this PR. |
Okay I see now. That wasn't the issue that was linked originally! You need to remove the words inside the square brackets on line 112 as well. |
removed words on line no.112
Is this okay that some checks have not passed? |
Checks that has not passed: https://github.com/TheOdinProject/curriculum/actions/runs/7585891383/job/20662765502 |
It's fine - it's a new action we implemented and fixing those is out of scope for your issue. |
Thank you. |
Because
Codeblocks should be updated to align with new changes in the layout style guide
This PR
Remove aforementioned link from the Node path's deployment lesson
Issue
Related to #26939
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section