Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #11467

Merged
merged 4 commits into from
Jun 17, 2024
Merged

chore: fix typos #11467

merged 4 commits into from
Jun 17, 2024

Conversation

xiaoxianBoy
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@xiaoxianBoy
chore: fix typos
1140fd4 
Signed-off-by: snoppy <michaleli@foxmail.com>
imSanko
imSanko approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are some serious Typos

tianyizheng02
tianyizheng02 requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found more typos but GitHub won't let me add comments on them:

  • On line 79 of points_are_collinear_3d.py, "or" is misspelled as "of"
  • On line 81 of that same file, "Since" is misspelled as "Sine"
  • On line 4 of convolution_neural_network.py, "Handing Writing" should be "Handwriting"
  • On line 307 of that same file, it says "Training Complished" but "Complished" isn't a real word; I think it's supposed to say "Complete"?
  • On line 356 of that same file, it says "on other file" but I think it's supposed to say "in another file"? I'm not sure what file the author was referring to

@cclauss @tianyizheng02
Apply suggestions from code review
2bf5a72 
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jun 17, 2024
@cclauss cclauss enabled auto-merge (squash) June 17, 2024 12:33
@cclauss
Copy link
Member

cclauss commented Jun 17, 2024

Were these misspellings found with a tool?

@cclauss cclauss requested a review from tianyizheng02 June 17, 2024 12:36
@tianyizheng02
Copy link
Contributor

Were these misspellings found with a tool?

No, I just visually inspected the files.

@cclauss cclauss merged commit 1cfca52 into TheAlgorithms:master Jun 17, 2024
3 checks passed
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@xiaoxianBoy @cclauss
@tianyizheng02 @sedatguzelsemme
chore: fix typos (TheAlgorithms#11467)
7351eb2 
* chore: fix typos

Signed-off-by: snoppy <michaleli@foxmail.com>

* Apply suggestions from code review

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

---------

Signed-off-by: snoppy <michaleli@foxmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@xiaoxianBoy @cclauss @tianyizheng02
chore: fix typos (TheAlgorithms#11467)
438d791 
* chore: fix typos

Signed-off-by: snoppy <michaleli@foxmail.com>

* Apply suggestions from code review

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

---------

Signed-off-by: snoppy <michaleli@foxmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@xiaoxianBoy @cclauss @tianyizheng02
chore: fix typos (TheAlgorithms#11467)
709a161 
* chore: fix typos

Signed-off-by: snoppy <michaleli@foxmail.com>

* Apply suggestions from code review

Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

---------

Signed-off-by: snoppy <michaleli@foxmail.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@imSanko imSanko imSanko approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoxianBoy @cclauss @tianyizheng02 @imSanko