-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle recording on legacy mode Windows consoles #2066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
- Coverage 99.52% 96.42% -3.10%
==========================================
Files 72 72
Lines 7335 7337 +2
==========================================
- Hits 7300 7075 -225
- Misses 35 262 +227
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… windows-capture-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@willmcgugan |
Type of changes
Checklist
Description
Console.record=True was only being handled inside
_render_buffer
, which was not called on legacy mode consoles.I've extracted the code for recording the buffer out of this method, to ensure it gets called regardless of environment.
Closes #2053