-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React imports 2 #7463
React imports 2 #7463
Conversation
5791b0b
to
f984210
Compare
I don't see any version updates in this PR, so I'm guessing a corresponding PR in the TerriaMap repository can be merged independently of this PR? |
f984210
to
1b489b9
Compare
@ljowen I have rebased this after the latest UI changes. |
1b489b9
to
f4c6761
Compare
@zoran995 I hadn't looked at the details of this PR but I just did a |
The React team recommends using named imports, which works because of automatic JSX support in Babel and TypeScript. When using automatic JSX, Babel and TypeScript detect the JSX syntax in the file and add |
What this PR does
Fixes: #7514
Supersedes the #7347, created new PR so build and deployment are available for testing
Small step toward #6538
Run upgrade-react-imports codemod to update react imports so they can work in react 17/18. Partially supersedes #7051.
Don't worry about merge conflicts first PR is only changes by codemod so it is easy to recreate
Test me
Tested locally
yarn gulp build
. All tests passes. Running the app locally worksChecklist
doc/
.