-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI update #7443
UI update #7443
Conversation
8fa34de
to
de1282d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for the review @zoran995 I've addressed most of these now except for 6), I'm in conversation with our designer about reverting to the small "Show workbench button" which would be my preference |
22d4930
to
d446557
Compare
Our client love the new changes! there is any ETA of them? |
b1c6ac3
to
a0071e8
Compare
- adjust story panel width - reduce max height on story body -> 200px, remove padding when collapsed - prettier - lint fixes in workbench
- BottomDock: pos relative on container - Remove bottom-dock.scss (no longer used) - adjust timeline spacing - minor cleanup - Check if mobile viewport when calculating splitter minX
- Fix icon alignment
- fix mapIcon fill color
…trols (i.e. feedback)
Workbench item border
… to white background for story body
Hi @irbian, thanks for the feedback. I also see that you have mentioned this before in #5169. To address your points:
I think this happens when we don't have those specific use cases in mind while making changes. It will be great if you can point out where specifically this has created problems and we will be happy to fix them.
As noted in #5169, this is a problem that comes with the switch to styled-components. One solution might be to expose more styling options as theme variables or customizable components. One problem I see with using external stylesheets for customizations is that it works like an implicit API that is more prone to accidental breakages when we change things in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
@ljowen - great job, looking good now 🎉
Our main case was to add a common organization level header to all apps in our domain, with links to other organizations apps. We did implement that one as a plugin that added a div just above the current header, but is something that would happen to any component added outside the frame
I can't speak about others, but for us it wouldn't be as much a problem as much as at least it would be possible to target the element to customization |
What this PR does
Major change to default theme and appearance:
May introduce breaking changes with existing maps so will be a major version.
Visual changes
Before


After
Functional changes
keepCatalogOpen
Test me
Before: http://ci.terria.io/main
After: http://ci.terria.io/ui-update-fonts
Checklist
doc/
.