Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI update #7443

Merged
merged 57 commits into from
Mar 5, 2025
Merged

UI update #7443

merged 57 commits into from
Mar 5, 2025

Conversation

ljowen
Copy link
Contributor

@ljowen ljowen commented Jan 13, 2025

What this PR does

Major change to default theme and appearance:
May introduce breaking changes with existing maps so will be a major version.

Visual changes

  • Generally increase padding
  • Workbench now "floating" with variable height and semi transparent background
  • Change to darker colours in default theme to increase contrast
  • Font changed from "Nunito" to "Inter", generally increase font sizes
  • More rounded corners, generally decrease border radius to 8px for major panels and 4px for smaller components

Before
before
After
after

Functional changes

  • Bug fixed where tour would not work correctly if workbench was minimised
  • Add config option to keep catalog open when adding / removing datasets keepCatalogOpen
  • Remove dataset count shown on map
  • Hide chart at mobile viewports

Test me

Before: http://ci.terria.io/main
After: http://ci.terria.io/ui-update-fonts

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

@ljowen ljowen marked this pull request as draft January 16, 2025 01:32
@zoran995

This comment was marked as resolved.

@ljowen
Copy link
Contributor Author

ljowen commented Jan 23, 2025

Thanks for the review @zoran995 I've addressed most of these now except for 6), I'm in conversation with our designer about reverting to the small "Show workbench button" which would be my preference

@irbian
Copy link
Contributor

irbian commented Jan 23, 2025

Our client love the new changes! there is any ETA of them?

@ljowen ljowen changed the title WIP: UI update UI update Jan 28, 2025
@ljowen ljowen marked this pull request as ready for review January 28, 2025 00:40
@ljowen ljowen force-pushed the ui-update-fonts branch 2 times, most recently from b1c6ac3 to a0071e8 Compare January 30, 2025 05:07
ljowen added 13 commits March 4, 2025 15:32
- adjust story panel width
- reduce max height on story body -> 200px, remove padding when collapsed
- prettier
- lint fixes in workbench
- BottomDock: pos relative on container
- Remove bottom-dock.scss (no longer used)
- adjust timeline spacing
- minor cleanup
- Check if mobile viewport when calculating splitter minX
- fix mapIcon fill color
Workbench item border
@ljowen ljowen force-pushed the ui-update-fonts branch from 781dfe6 to 5da1920 Compare March 4, 2025 05:33
@ljowen ljowen force-pushed the ui-update-fonts branch from 5da1920 to e51b8eb Compare March 4, 2025 05:48
@na9da
Copy link
Collaborator

na9da commented Mar 4, 2025

Hi @irbian, thanks for the feedback. I also see that you have mentioned this before in #5169.

To address your points:

The reliance on vh and vw means that we can't add elements freely above or below the frame

I think this happens when we don't have those specific use cases in mind while making changes. It will be great if you can point out where specifically this has created problems and we will be happy to fix them.

The use of generated classes instead of semantic ones makes difficult to attach external styles to them

As noted in #5169, this is a problem that comes with the switch to styled-components. One solution might be to expose more styling options as theme variables or customizable components.

One problem I see with using external stylesheets for customizations is that it works like an implicit API that is more prone to accidental breakages when we change things in the UI.

@ljowen ljowen force-pushed the ui-update-fonts branch from cd35d72 to 81cd774 Compare March 5, 2025 00:24
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@ljowen - great job, looking good now 🎉

@ljowen ljowen merged commit fe61b9e into main Mar 5, 2025
9 checks passed
@ljowen ljowen deleted the ui-update-fonts branch March 5, 2025 04:01
@irbian
Copy link
Contributor

irbian commented Mar 5, 2025

Hi @irbian, thanks for the feedback. I also see that you have mentioned this before in #5169.

To address your points:

The reliance on vh and vw means that we can't add elements freely above or below the frame

I think this happens when we don't have those specific use cases in mind while making changes. It will be great if you can point out where specifically this has created problems and we will be happy to fix them.

Our main case was to add a common organization level header to all apps in our domain, with links to other organizations apps. We did implement that one as a plugin that added a div just above the current header, but is something that would happen to any component added outside the frame

The use of generated classes instead of semantic ones makes difficult to attach external styles to them

As noted in #5169, this is a problem that comes with the switch to styled-components. One solution might be to expose more styling options as theme variables or customizable components.

One problem I see with using external stylesheets for customizations is that it works like an implicit API that is more prone to accidental breakages when we change things in the UI.

I can't speak about others, but for us it wouldn't be as much a problem as much as at least it would be possible to target the element to customization

@zoran995 zoran995 mentioned this pull request Mar 7, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants