Update gradio_app.py I did it badly and it's not acceptable. Sorry to anyone that's hit the huge slowdown this made to even the stock settings. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I messed up. BAD. The changes i implemented initiall, whilst they DID allow me to massivley increase the quality of the output file, for some reason.. it also caused the whole program to run like garbage, even on the default settings, regardless of the options.. which is a bit dumb on my part. I thought the slowdown was purely cos of me running it harder. Very clearly not! fooled around a bit and made some more changes (probably a ton more than I needed lol) and it does appear to exhibit correct behaviour and is WAAAY faster now. Sorry for this total messup!!
|
Well, either that or just the single change of deleting this line entirely that was meant to be gpu to make sure it ran on gpu only, but typo .. then realised some people might actually want to try run it on cpu so like.. someone please pick deletign the line or adopting the messier changes i've made :) Sorry again x |
YanWenKun
added a commit
to YanWenKun/Hunyuan3D-2
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up. BAD.
The changes i implemented initiall, whilst they DID allow me to massivley increase the quality of the output file, for some reason.. it also caused the whole program to run like garbage, even on the default settings, regardless of the options.. which is a bit dumb on my part. I thought the slowdown was purely cos of me running it harder. Very clearly not!
fooled around a bit and made some more changes (probably a ton more than I needed lol) and it does appear to exhibit correct behaviour and is WAAAY faster now.
Sorry for this total messup!!
Promise this one is good <3