Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support run unit test, cucumber test, code format in osrm-backend-dev #379

Closed
wangyoucao577 opened this issue Oct 22, 2020 · 5 comments · Fixed by #380
Closed

Support run unit test, cucumber test, code format in osrm-backend-dev #379

wangyoucao577 opened this issue Oct 22, 2020 · 5 comments · Fixed by #380
Assignees
Labels
Chore e.g. build, pipeline, etc. no production change. Testing
Milestone

Comments

@wangyoucao577
Copy link

  • Install node
  • Install clang-format
@wangyoucao577 wangyoucao577 added Testing Chore e.g. build, pipeline, etc. no production change. labels Oct 22, 2020
@wangyoucao577 wangyoucao577 added this to the v10.4.0 milestone Oct 22, 2020
@wangyoucao577 wangyoucao577 self-assigned this Oct 22, 2020
@wangyoucao577
Copy link
Author

wangyoucao577 commented Oct 22, 2020

Testing related docs:

From Project-OSRM#5720, node should be at max version 10.
From Project-OSRM#5667, gcc 8 seems not work either, has to be gcc 6.

@wangyoucao577
Copy link
Author

From https://github.com/Project-OSRM/osrm-backend/blob/1ba8aba4663590c5c53b3b0a9989e4fe605b45b8/scripts/format.sh#L33, the clang-format version has to be 3.8. Try apt-get install clang-format-3.8 on debian/ubuntu.

@wangyoucao577
Copy link
Author

Testing related docs:

From Project-OSRM#5720, node should be at max version 10.
From Project-OSRM#5667, gcc 8 seems not work either, has to be gcc 6.

In my test, gcc 8 or node 14 still can not work. gcc 6 + node 10 work well.

@wangyoucao577
Copy link
Author

wangyoucao577 commented Oct 22, 2020

Tested:

npm install --unsafe-perm
rm -rf build && rm -f lib/binding/*

# build NodeJS bindings with C++ binaries together 
./scripts/node_install.sh
ll lib/binding/

# run cucumber test via npm
npm test

# OR via cucumber directly
./node_modules/.bin/cucumber-js

# format code
./scripts/format.sh

@wangyoucao577
Copy link
Author

npm install --unsafe-perm --build-from-source doesn't work for me. See more discuss in Project-OSRM#5776.

build api docs(npm run docs) doesn't work either, will be discussed in Project-OSRM#5867.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore e.g. build, pipeline, etc. no production change. Testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant