Ios 9356 rename crouton to snackbar #427
Merged
+253
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amegias
reviewed
Feb 20, 2025
| import UIKit | ||
|
|
||
| // Protocol implemented by view controllers that want to Snackbar in a very specific view | ||
| @objc public protocol CustomSnackbarContainer { |
There was a problem hiding this comment.
new??? in that case, remove @objc pls
There was a problem hiding this comment.
Just moved and renamed the file, no logic changes in this PR.
File in main:
`
import UIKit
// Protocol implemented by view controllers that want to show croutons in a very specific view
@objc public protocol CustomCroutonContainer {
var customCroutonContainerView: UIView { get }
}
`
amegias
reviewed
Feb 20, 2025
|
|
||
| | `Info` | `Critical` | | ||
| |-----------------------------------------------|---------------------------------------------------| | ||
| |  |  | |
| @@ -20,29 +20,29 @@ public class CroutonController: NSObject { | |||
| public typealias DismissHandlerBlock = (SnackbarDismissReason) -> Void | |||
| public typealias DidTapActionBlock = () -> Void | |||
|
|
|||
| private var croutonViewList = [OngoingCrouton]() | |||
| private var SnackbarViewList = [OngoingSnackbar]() | |||
There was a problem hiding this comment.
Suggested change
| private var SnackbarViewList = [OngoingSnackbar]() | |
| private var snackbarViewList = [OngoingSnackbar]() |
amegias
approved these changes
Feb 21, 2025
L-Trujillo26
added a commit
that referenced
this pull request
Mar 18, 2025
BREAKING CHANGE: Renamed "Crouton" to "Snackbar". Updated UI for Snackbar component. * IOS-9356 Adjust crouton constraints above the tabbar or the safe area * IOS-9356 adjust crouton border radius and update close button size * Run swiftformat * ci(secrets): Update firebase secret (#420) * IOS-9356 update the close button of the crouton and optimize the view constraints logic * Run swiftformat * Record screenshots automatically launched from GH action * IOS-9356 Add tests for floating crouton behavior in UIScrollView and when a TabTar is present * Run swiftformat * IOS-9356 update crouton tests and undo changes in GitHub configuration file * IOS-9356 update crouton with tabbar test * Run swiftformat * IOS-9356 improved crouton tests * Run swiftformat * IOS-9356 ensure crouton only detects bottom tabbar and fix pr comments * Run swiftformat * IOS-9356 fix crouton animation * IOS-9356 fix crouton constraints to handle UIscrollview safe area * IOS-9356 fix snackbar constrains in uiscrollview case * IOS-9356 update snackbar animation * Run swiftformat * IOS-9356 fix snackbar animation * Run swiftformat * Ios 9356 rename crouton to snackbar (#427) * IOS-9356 rename crouton to snackbar and update README * IOS-9356 continue renaming crouton component to snackbar * IOS-9356 continue crouton renaming * IOS-9356 fix images name and some changes in the crouton renaming * IOS-9356 fix snackbar readme and icons name * IOS-9356 update readme images * IOS-9356 rename snackbar style config * Ios 9356 rename crouton tests (#429) * IOS-9356 rename crouton tests and update screenshots * IOS-9356 disable recording in snackbar tests * Run swiftformat --------- Co-authored-by: L-Trujillo26 <L-Trujillo26@users.noreply.github.com> --------- Co-authored-by: L-Trujillo26 <L-Trujillo26@users.noreply.github.com> * Ios 9356 update crouton buttons (#435) * IOS-9356 update crouton buttons * IOS-9356 fix merge issue and animation that was breaking tests * Run swiftformat * IOS-9356 changed text button color to the updated spec * IOS-9356 restore var * Run swiftformat * IOS-11139 updated snackbar readme * IOS-9356 Added the token again to ensure that the snackbar which is intended to be dismissed is the one presented currently. * Run swiftformat --------- Co-authored-by: L-Trujillo26 <L-Trujillo26@users.noreply.github.com> Co-authored-by: Pablo Bartolome <pablo.bartolomeherranz@telefonica.com> Co-authored-by: José Manuel Rodríguez Moreno <josemanuel.rodriguezmoreno@telefonica.com> Co-authored-by: idenjoe <idenjoe@users.noreply.github.com>
tuentisre
pushed a commit
that referenced
this pull request
Mar 19, 2025
# [34.0.0](v33.8.0...v34.0.0) (2025-03-19) ### Bug Fixes * **semantic-release:** IOS-11147 Update node version as a dependency of the latest semantic-release version. ([#440](#440)) ([17e4001](17e4001)) * **semantic-release:** IOS-11147 Update semantic release to v24.2.3 ([#438](#438)) ([c632beb](c632beb)) * **updateVersionScript:** IOS-11147 Fix the update version script to be compatible with Ubuntu sed version (GNU sed) instead of macOS sed (BSD sed). ([#442](#442)) ([4609b69](4609b69)) * **updateVersionScript:** IOS-11147 Update releasrc and update_version script to be executed in… ([#441](#441)) ([414bc7e](414bc7e)) ### Features * **Crouton:** IOS-11139 Remove crouton queue to avoid enqueuing messages. From now … ([#437](#437)) ([827964b](827964b)) * **Snackbar:** Deprecate Crouton, introduce new Snackbar UI ([#422](#422)) ([da64cea](da64cea)), closes [#420](#420) [#427](#427) [#429](#429) ### BREAKING CHANGES * **Snackbar:** Renamed "Crouton" to "Snackbar". Updated UI for Snackbar component. * IOS-9356 Adjust crouton constraints above the tabbar or the safe area * IOS-9356 adjust crouton border radius and update close button size * Run swiftformat * **Crouton:** UIKit Crouton no longer allows message queuing. If a new crouton is presented, the previous one will be discarded. showCrouton and dismiss CroutonController methods have been modified to remove the token we used to dismiss a specific crouton. * IOS-11139 Remove crouton queue to avoid enqueuing messages. From now if a new crouton is launched, the previous one will be removed. * Run swiftformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-9356
🥅 What's the goal?
Rename Crouton component to Snackbar
🚧 How do we do it?
Rename the component.
Update readme.
:
🧪 How can I verify this?
Catalog -> snackbar
snackbar.mov
🏑 AppCenter build