[Feature/#68] university selection api #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Jul 16, 2024
| internal abstract class DataSourceModule { | ||
| @Binds | ||
| @Singleton | ||
| abstract fun bindUniversitySelectionDataSource( |
There was a problem hiding this comment.
Suggested change
| abstract fun bindUniversitySelectionDataSource( | |
| abstract fun bindsUniversitySelectionDataSource( |
오타수정해주세요
| object ServiceModule { | ||
| @Provides | ||
| @Singleton | ||
| fun provideUniversitySelectionService(@JWT retrofit: Retrofit): UniversitySelectionService = |
Comment on lines
21
to
26
| val dto = UniversitySelectionRequestDto( | ||
| universityId = request.universityId, | ||
| name = request.name, | ||
| longitude = request.longitude, | ||
| latitude = request.latitude | ||
| ) |
Comment on lines
14
to
17
| return runCatching { | ||
| val response = dataSource.getUniversitySelection() | ||
| response.data.universities.map { it.toUniversitySelectionEntity() } | ||
| } |
Comment on lines
7
to
30
| @Serializable | ||
| data class University( | ||
| @SerialName("id") | ||
| val id: Int, | ||
| @SerialName("name") | ||
| val name: String, | ||
| @SerialName("longitude") | ||
| val longitude: Double, | ||
| @SerialName("latitude") | ||
| val latitude: Double | ||
| ) { | ||
| fun toUniversitySelectionEntity() = UniversitySelectionEntity( | ||
| id = id, | ||
| name = name, | ||
| longitude = longitude, | ||
| latitude = latitude, | ||
| ) | ||
| } | ||
|
|
||
| @Serializable | ||
| data class UniversitySelectionResponseDto( | ||
| @SerialName("universities") | ||
| val universities: List<University> | ||
| ) |
There was a problem hiding this comment.
호출되는 순서대로 선언해주세요
Suggested change
| @Serializable | |
| data class University( | |
| @SerialName("id") | |
| val id: Int, | |
| @SerialName("name") | |
| val name: String, | |
| @SerialName("longitude") | |
| val longitude: Double, | |
| @SerialName("latitude") | |
| val latitude: Double | |
| ) { | |
| fun toUniversitySelectionEntity() = UniversitySelectionEntity( | |
| id = id, | |
| name = name, | |
| longitude = longitude, | |
| latitude = latitude, | |
| ) | |
| } | |
| @Serializable | |
| data class UniversitySelectionResponseDto( | |
| @SerialName("universities") | |
| val universities: List<University> | |
| ) | |
| @Serializable | |
| data class UniversitySelectionResponseDto( | |
| @SerialName("universities") | |
| val universities: List<University> | |
| ) | |
| @Serializable | |
| data class University( | |
| @SerialName("id") | |
| val id: Int, | |
| @SerialName("name") | |
| val name: String, | |
| @SerialName("longitude") | |
| val longitude: Double, | |
| @SerialName("latitude") | |
| val latitude: Double | |
| ) { | |
| fun toUniversitySelectionEntity() = UniversitySelectionEntity( | |
| id = id, | |
| name = name, | |
| longitude = longitude, | |
| latitude = latitude, | |
| ) | |
| } |
| universities: PersistentList<UniversitySelectionModel>, | ||
| selectedUniversity: String?, | ||
| onSelectUniversity: (String) -> Unit, | ||
| universities: List<UniversitySelectionEntity>, |
| isSelected = selectedUniversity == university.name, | ||
| onSelectUniversity = onSelectUniversity | ||
| isSelected = selectedUniversity == university, | ||
| onSelectUniversity = { onSelectUniversity(university) } |
| val universities: List<UniversitySelectionEntity> = emptyList(), |
There was a problem hiding this comment.
State에서도 List -> PersistantList 해주세요
| ).sortedBy { it.name } | ||
| _universitySelectionState.value = | ||
| _universitySelectionState.value.copy(universities = dummyData) | ||
| val result = universitySelectionRepository.getUniversitySelection() |
Comment on lines
44
to
67
| val selectedUniversity = _universitySelectionState.value.selectedUniversity | ||
| if (selectedUniversity != null) { | ||
| val request = UniversitySelectionRequest( | ||
| universityId = selectedUniversity.id.toLong(), | ||
| name = selectedUniversity.name, | ||
| longitude = selectedUniversity.longitude, | ||
| latitude = selectedUniversity.latitude | ||
| ) | ||
| viewModelScope.launch { | ||
| val result = universitySelectionRepository.postUniversitySelection(request) | ||
| result.onSuccess { university -> | ||
| val updatedUniversities = | ||
| _universitySelectionState.value.universities + university | ||
|
|
||
| _universitySelectionState.value = _universitySelectionState.value.copy( | ||
| universities = updatedUniversities | ||
| ) | ||
| }.onFailure { | ||
| // 에러 처리 | ||
| } | ||
| } | ||
| } | ||
| } |
hyeeum
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
university-selection-apimp4.mp4
📢 To Reviewers