Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#62] my new jogbo #76

Merged
merged 18 commits into from
Jul 17, 2024
Merged

[Feature/#62] my new jogbo #76

merged 18 commits into from
Jul 17, 2024

Conversation

hyeeum
Copy link
Contributor

@hyeeum hyeeum commented Jul 16, 2024

⛳️ Work Description

  • 텍스트필드 커스텀
  • 네비게이터 연결

📸 Screenshot

KakaoTalk_20240706_044223863.mp4

📢 To Reviewers

  • HankkiCountTextField 해석하기 어려울 것 같아서(저는 어려웠음) 주석도 같이 달아서 PR올릴게요! 병합할때 지우고 병합하겠습니당
  • 텍스트필드....어렵다 어려워...
  • 피그마 컴포넌트 프레임에 있어서 core에 넣긴했는데 my모듈로 변경할까요? 약간 의문...
  • 나도 서버 통신 하고 싶어요ㅠ
  • 커밋 메세지가...왜..왜저러죠 이제 발견했네요..죄송합니다 ㅜ.ㅜ

@hyeeum hyeeum added this to the 1차 스프린트 UI 작업 milestone Jul 16, 2024
@hyeeum hyeeum requested review from chattymin and 0se0 July 16, 2024 18:17
@hyeeum hyeeum self-assigned this Jul 16, 2024
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어려운 기능이었는데 고생하셨습니다 :)

keyboardActions: KeyboardActions = KeyboardActions.Default
) {
var isFocused by remember { mutableStateOf(false) }
var textFieldValue by remember { mutableStateOf(TextFieldValue(text = value)) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value는 state로 hoisting 해주세요~

@hyeeum hyeeum requested a review from chattymin July 16, 2024 20:37
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!!
state hoisting은 앱잼 끝나고 수정해주세요 :)

Copy link
Member

@0se0 0se0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@hyeeum hyeeum merged commit 5f93239 into develop Jul 17, 2024
@hyeeum hyeeum deleted the feature/#62-my-new-jogbo branch July 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Mypage - 족보 만들기
3 participants