Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#37] login context issue #39

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

0se0
Copy link
Member

@0se0 0se0 commented Jul 10, 2024

⛳️ Work Description

  • ViewModel에서 Context를 사용한 부분을 ApplicationContext로 바꿨습니다.

📸 Screenshot

기존 화면과 동일합니다.

📢 To Reviewers

  • 다음부턴 더 꼼꼼히 구현하도록 하겠습니다..ㅎ
    이 부분 봐주신 팟짱님께 감사 인사를 드립니다.🙌

@0se0 0se0 added the FIX 🛠️ 버그 및 오류 해결 label Jul 10, 2024
@0se0 0se0 added this to the 1차 스프린트 서버 작업 milestone Jul 10, 2024
@0se0 0se0 requested review from chattymin and hyeeum July 10, 2024 17:13
@0se0 0se0 self-assigned this Jul 10, 2024
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 열심히 코리달도록 하겠습니다... ㅠㅠ
고생했서요!!

@@ -19,43 +20,44 @@ import javax.inject.Inject
@HiltViewModel
class LoginViewModel @Inject constructor(
private val loginRepository: LoginRepository,
private val tokenRepository: TokenRepository
private val tokenRepository: TokenRepository,
@ApplicationContext private val context: Context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 이걸 못봤었네요...
꼼꼼히 리뷰 못했어서 죄송합니다 🙇🏻‍♂️

Copy link
Contributor

@hyeeum hyeeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뷰모델에 컨텍스트 넣지 않기..! 같이 알아갑니다 :-)

@0se0 0se0 merged commit e499c12 into develop Jul 10, 2024
@0se0 0se0 deleted the feature/#37-login-context-issue branch July 10, 2024 17:40
@0se0 0se0 restored the feature/#37-login-context-issue branch July 10, 2024 17:40
@0se0 0se0 changed the title [Feature/#37] login context issue [Fix/#37] login context issue Jul 11, 2024
@0se0 0se0 deleted the feature/#37-login-context-issue branch July 12, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🛠️ 버그 및 오류 해결 세영 🦌
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] Login viewmodel context issue
3 participants