Feature/#247 store detail edit #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Nov 16, 2024
Comment on lines
+472
to
+490
| Box(modifier = Modifier.width(32.dp)) { | ||
| if (showDeleteButton) { | ||
| Column { | ||
| Text( | ||
| text = "", | ||
| style = HankkiTheme.typography.body8, | ||
| color = Color.Transparent | ||
| ) | ||
| Spacer(modifier = Modifier.height(11.dp)) | ||
| Icon( | ||
| painter = painterResource(id = R.drawable.ic_circle_x), | ||
| contentDescription = "delete", | ||
| tint = Gray300, | ||
| modifier = Modifier | ||
| .size(32.dp) | ||
| .noRippleClickable(onClick = deleteMenu) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
showDeleteButton이 false일 때 Box에 해당하는 영역은 존재할거같아요!
두가지 궁금증이 있어요
- Box로 묶은 이유가 있나요? 단순 width라면 Column에서 처리해도 될 것 같아요! 그게 아니라면 Box도 같이 If문 안에 있는건 어떨까요?
- Text에는 값이 없는데 들어간 이유가 있는걸까용?
There was a problem hiding this comment.
- 리스트가 하나 남아있을 상황에서는 delete 버튼을 없애자는 의견이 나와서 이렇게 구현하였습니다!
- text부분 만큼의 크기를 주어서 delete 버튼의 위치를 조정한 것입니다!
feature/report/src/main/java/com/hankki/feature/report/main/ReportRoute.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/hankki/feature/storedetail/editbottomsheet/add/addmenu/AddMenuViewModel.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/editmenu/EditMenuRoute.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/editmenu/EditMenuState.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Issue
⛳️ Work Description
-2차 스프린트
📸 Screenshot
동영상
3.mp4
이미지
📢 To Reviewers