Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs #250] Change PR template #251

Merged
merged 1 commit into from
Oct 6, 2024
Merged

[Docs #250] Change PR template #251

merged 1 commit into from
Oct 6, 2024

Conversation

chattymin
Copy link
Member

@chattymin chattymin commented Oct 6, 2024 •
edited
Loading

⛳️ Work Description

  • PR템플릿을 수정했어요
  • UI테스트를 추후 넣을 예정인데, 그 전까지는 수동으로라도 전 후를 파악할 수 있어야 할 것 같아요

📢 To Reviewers

  • 정적인 UI만 변경되었다면 스크린샷으로 전후를 나타내주면 됩니다
  • 없는 기능을 개발하였다면 영상으로 하나만 넣어주시면 됩니다.
  • 이미 있는 기능을 UI를 포함하여 개선하였다면 영상으로 전후를 나타내주세요.
  • Screenshot 부분의 경우 "제목-사진or영상" 의 포멧이라면 자유롭게 변경해도 좋아요
    ex) [Feature #245] mypage redesign #246

@chattymin chattymin requested review from hyeeum and 0se0 October 6, 2024 06:05
@chattymin chattymin self-assigned this Oct 6, 2024
hyeeum
hyeeum approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@hyeeum hyeeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이거 매번 만들기 귀찮았는데 감사합니다 히히 :)

0se0
0se0 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@0se0 0se0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당.

@chattymin chattymin merged commit 963e4c1 into develop Oct 6, 2024
@chattymin chattymin deleted the feature/#250-change-PR-template branch October 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeeum hyeeum hyeeum approved these changes

@0se0 0se0 0se0 approved these changes

Assignees

@chattymin chattymin

Labels
DOCS 📝 문서 작업 동민 👻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] PR Template Change
3 participants
@chattymin @hyeeum @0se0