[Fix/#218] 2nd my qa #219
Merged
[Fix/#218] 2nd my qa #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Aug 23, 2024
| @@ -195,7 +195,7 @@ fun MyJogboDetailScreen( | |||
| title = jogboTitle, | |||
| chips = jogboChips, | |||
| userNickname = userNickname, | |||
| shareJogbo = updateShareDialogState | |||
| shareJogboDialog = updateShareDialogState | |||
There was a problem hiding this comment.
State는 네이밍 맞추는게 어떨까용~
Suggested change
| shareJogboDialog = updateShareDialogState | |
| shareJogboDialogState = updateShareDialogState |
There was a problem hiding this comment.
아 이거 전 PR에도 비슷하게 코멘트 달렸는데...또..놓쳤네요..제가....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
이전과 동일합니다!
📢 To Reviewers