[Feature/#186] login message #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Aug 19, 2024
Comment on lines
101
to
119
| private fun showReLoginMessage() { | ||
| Handler(Looper.getMainLooper()).post { | ||
| showCustomToast() | ||
| } | ||
| } | ||
|
|
||
| private fun showCustomToast() { | ||
| val inflater = LayoutInflater.from(context) | ||
| val layout = inflater.inflate(R.layout.custom_toast, null) | ||
|
|
||
| val text: TextView = layout.findViewById(R.id.toast_text) | ||
| text.setText(R.string.relogin_message) | ||
|
|
||
| Toast(context).apply { | ||
| duration = Toast.LENGTH_SHORT | ||
| setView(layout) | ||
| show() | ||
| } | ||
| } |
There was a problem hiding this comment.
custom Toast를 사용하면 에러가 발생한다는게 혹시 어떤 오류일까요??
크리티컬 하다면 그냥 기본 토스트 사용해도 괜찮을 것 같아요!!
어차피 사용자에게 자주 발생될 일도 아니라 통일성이 조금은 깨져도 될 것 같아용
There was a problem hiding this comment.
에러는 아니고 setView가 deprecated된 아이더라구요..! 그래서 고민을 좀 했었습니다.
그래서 저도 기본 토스트로 사용하는 것이 더 좋을 거 같다고 생각합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
토스트 메세지 확인은 서버에서 만료기간을 짧게 하였을 때 확인이 가능할 것 같습니다.
(현재는 만료된 엑세스 토큰을 강제로 넣어서 리프레시가 제대로 발급되는지 로그로 확인할 수 있습니다.)
📢 To Reviewers