-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebinding a powered spawner loses it's capacitor and settings #999
Rebinding a powered spawner loses it's capacitor and settings #999
Conversation
Looks good but I am not sure whether this is the right way to tackle this as it feels very hardcoded. |
Yeah, I agree, I really don't like how hard coded it is. This is the only case where we would want to do this at the moment (and couldn't think of any other likely examples). I will look into adding the boolean. |
Added more flexible solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be enough to copy the components over
...machines/src/main/java/com/enderio/machines/common/blocks/soul_binder/SoulBindingRecipe.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Darshan Phaldesai <51489635+dphaldes@users.noreply.github.com>
That's much neater. I missed that method. Thanks. |
Description
When rebinding a powered spawner it's capacitor and all its settings are lost.
The fix for this is very hard coded but I can't see any other way around it.
Checklist