Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused count in sized tag output #991

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix unused count in sized tag output #991

merged 1 commit into from
Feb 12, 2025

Conversation

rlnt
Copy link
Contributor

@rlnt rlnt commented Feb 4, 2025

Description

This pull request fixes the unused count property in the SizedTagOutput. Right now it's only used in the codec and not made use of. Thus, tag outputs can never have a higher count than 1.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Rover656
Rover656 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, and apologies for the delay in review.

@Rover656 Rover656 merged commit 4061eac into Team-EnderIO:dev/1.21.1 Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlnt @Rover656