Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes disconnections of blocks from the conduit network to remain a
DynamicConnectionState
, from wrench or gui interactions. This fixes an issue with the GUI opening an invalid connection and not being able to change any settings. It also simply improves the usability of disconnected conduits, as without this change, it would be fairly annoying to reconnect them, especially with a multi-conduit bundle.I decided to not drop any filters when the connection is disabled, and instead only when the conduit or block it's connected to is broken. That could be changed though.
To reproduce the GUI issue without these changes, place an item and fluid conduit next to a fluid tank and disconnect the item conduit, then click on the item conduit in the bundle.

I'm aware that this bug could be fixed in other ways, but I chose this one because of the usability reasons.
Checklist