Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conduit disconnections #880

Open
wants to merge 2 commits into
base: dev/1.20.1
Choose a base branch
from

Conversation

Metalit
Copy link
Contributor

@Metalit Metalit commented Oct 31, 2024

Description

Changes disconnections of blocks from the conduit network to remain a DynamicConnectionState, from wrench or gui interactions. This fixes an issue with the GUI opening an invalid connection and not being able to change any settings. It also simply improves the usability of disconnected conduits, as without this change, it would be fairly annoying to reconnect them, especially with a multi-conduit bundle.

I decided to not drop any filters when the connection is disabled, and instead only when the conduit or block it's connected to is broken. That could be changed though.

To reproduce the GUI issue without these changes, place an item and fluid conduit next to a fluid tank and disconnect the item conduit, then click on the item conduit in the bundle.
2024-10-31_16 27 05
I'm aware that this bug could be fixed in other ways, but I chose this one because of the usability reasons.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@CitiesXL2815 CitiesXL2815 added the Area-Conduits Everything involving conduits label Dec 5, 2024
@Rover656 Rover656 self-requested a review December 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Conduits Everything involving conduits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants