Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(query-core): add hashQueryKeyByOptions test code #8736

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(query-core): add hashQueryKeyByOptions test code #8736

wants to merge 4 commits into from

Conversation

dngur9801
Copy link

No description provided.

TkDodo
TkDodo reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn’t test the byOptions part, because options are never passed to hashQueryKeyByOptions in these tests.

so this is essentially the same as #8735 right now

@dngur9801
Copy link
Author

I modified the test code to verify that when the queryKeyHashFn option is provided, the specified hash function is called, and when it is not, the default hashKey function is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo left review comments

Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dngur9801 @TkDodo