Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isSubmitSuccessful prop #919

Merged
merged 5 commits into from
Mar 1, 2025
Merged

Conversation

s-coimbra21
Copy link
Contributor

@s-coimbra21 s-coimbra21 commented Aug 21, 2024

This adds a new prop the form state called isSubmitSuccessful. My use case for this is that there is no good way to keep input/submission disabled when a form that calls a server action which redirects the user when the form is successful.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, great value add!

Copy link

nx-cloud bot commented Oct 22, 2024

View your CI Pipeline Execution ↗ for commit c553f73.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 15s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-01 10:35:29 UTC

Copy link

pkg-pr-new bot commented Oct 22, 2024

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (faea151) to head (c553f73).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   88.50%   88.68%   +0.17%     
==========================================
  Files          28       28              
  Lines        1253     1255       +2     
  Branches      327      327              
==========================================
+ Hits         1109     1113       +4     
+ Misses        129      127       -2     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit da5026e into TanStack:main Mar 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants