-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add isSubmitSuccessful prop #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, great value add!
View your CI Pipeline Execution ↗ for commit c553f73.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 88.50% 88.68% +0.17%
==========================================
Files 28 28
Lines 1253 1255 +2
Branches 327 327
==========================================
+ Hits 1109 1113 +4
+ Misses 129 127 -2
Partials 15 15 ☔ View full report in Codecov by Sentry. |
This adds a new prop the form state called
isSubmitSuccessful
. My use case for this is that there is no good way to keep input/submission disabled when a form that calls a server action which redirects the user when the form is successful.