Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Angular 17.3 and Angular 18.x support #1043

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

crutchcorn
Copy link
Member

This PR drops support for Angular 17.3 and Angular 18.x

This means that only Angular 19+ is supported

This is a result of catching a very dangerous bug that was fixed using an Angular 19 API of linkedSignal that seemingly cannot be backported.

Immense apologies for this breaking change prior to 1.x

Copy link

nx-cloud bot commented Nov 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b78c5b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 29, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1043

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1043

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1043

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1043

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1043

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1043

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1043

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1043

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1043

commit: b78c5b2

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (add-ts-54-plus-tests@0a08f26). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             add-ts-54-plus-tests    #1043   +/-   ##
=======================================================
  Coverage                        ?   86.10%           
=======================================================
  Files                           ?       28           
  Lines                           ?     1108           
  Branches                        ?      278           
=======================================================
  Hits                            ?      954           
  Misses                          ?      141           
  Partials                        ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 28f89af into add-ts-54-plus-tests Nov 29, 2024
6 of 7 checks passed
@crutchcorn crutchcorn deleted the angular-19-support branch November 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant