Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): run form submit validator once on submit #1028

Merged

Conversation

Balastrong
Copy link
Member

This PR fixes #1027

Form is already validated during field-level validation, no need to explicitly run it again on submit.

Copy link

nx-cloud bot commented Nov 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3fe97a3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 19, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@1028

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@1028

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@1028

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@1028

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@1028

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@1028

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@1028

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@1028

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@1028

commit: 3fe97a3

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (5473bb8) to head (3fe97a3).
Report is 165 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   91.55%   86.24%   -5.32%     
==========================================
  Files          21       28       +7     
  Lines         900     1105     +205     
  Branches      206      278      +72     
==========================================
+ Hits          824      953     +129     
- Misses         71      140      +69     
- Partials        5       12       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Balastrong Balastrong merged commit 72516f1 into TanStack:main Nov 19, 2024
6 of 7 checks passed
@Balastrong Balastrong deleted the fix/run-form-submit-validator-once branch November 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onSubmitAsync validation runs twice on submit
1 participant