fix: subfield data is removed properly when calling removeFieldValue (#…

…1197)
TanStack · Mar 1, 2025 · c8cfbe0 · c8cfbe0
1 parent 2d04246
commit c8cfbe0
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 0 deletions.
diff --git a/packages/form-core/src/metaHelper.ts b/packages/form-core/src/metaHelper.ts
@@ -110,6 +110,8 @@ export function metaHelper<
       const nextFieldMeta = formApi.getFieldMeta(nextFieldKey)
       if (nextFieldMeta) {
         formApi.setFieldMeta(fieldKey, nextFieldMeta)
+      } else {
+        formApi.setFieldMeta(fieldKey, getEmptyFieldMeta())
       }
     })
   }

diff --git a/packages/form-core/tests/FieldApi.spec.ts b/packages/form-core/tests/FieldApi.spec.ts
@@ -1760,4 +1760,49 @@ describe('field api', () => {
     nameField.mount()
     expect(nameField.getMeta().errors).toEqual(['THERE IS AN ERROR'])
   })
+
+  it('should remove the meta from deleted fields', async () => {
+    const form = new FormApi({
+      defaultValues: {
+        names: [
+          {
+            firstName: 'John',
+            lastName: '',
+          },
+          {
+            firstName: 'Martha',
+            lastName: 'Mustermann',
+          },
+        ],
+      },
+    })
+
+    const field = new FieldApi({
+      form,
+      name: `names[${0}].lastName`,
+      validators: {
+        onMount: ({ value }) =>
+          value.length > 0 ? undefined : 'Last name is required',
+        onChange: ({ value }) =>
+          value.length > 0 ? undefined : 'Last name is required',
+      },
+    })
+
+    form.mount()
+    field.mount()
+
+    expect(form.state.canSubmit).toBe(false)
+
+    await form.removeFieldValue('names', 0)
+
+    expect(form.getFieldValue('names')).toEqual([
+      {
+        firstName: 'Martha',
+        lastName: 'Mustermann',
+      },
+    ])
+
+    expect(field.getMeta().errors).toStrictEqual([])
+    expect(form.state.canSubmit).toBe(true)
+  })
 })