feat(ui): re-implement tag display names on sql #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: QoL
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-implements tag "display names" found in v9.4 and below of TagStudio. This system uses a marked parent tag to provide an extra name in parenthesis following the original tag's name for optional disambiguation.
The ordered choices of tag names are as follows:
Where this PR differs from the JSON implementation is that instead of using the first parent tag in the list as the disambiguation tag, the user can now choose between any parent tags to use for the display name, including none. This UI uses a radio button group with the added ability to allow for no selection at all.