-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: about section #712
feat: about section #712
Conversation
6d9651d
to
d2738de
Compare
missing translations! |
d2738de adds code from v9.4 which also includes a warning popup when the program launces if no ffmpeg install is found. |
Is there anything else you want to add to this PR? Because otherwise I will move it to pending merge |
Translations, and i also need to either figure out how to get the current config path or remove that line. |
That should be all, as i realized translations are managed by weblate and not normal prs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking good!
(A nice to have would be being able to click the config path and having it open in the file application, but that could also just be a future PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this! I'll add @seakrueger as a co-author to credit him for his contributions brought over from #441.
Adds an AboutModal with some basic info about the program like version number, license, and github/discord link.