Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: about section #712

Merged
merged 12 commits into from
Jan 22, 2025
Merged

feat: about section #712

merged 12 commits into from
Jan 22, 2025

Conversation

mashed5894
Copy link
Contributor

Adds an AboutModal with some basic info about the program like version number, license, and github/discord link.

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience labels Jan 18, 2025
@mashed5894
Copy link
Contributor Author

missing translations!

@mashed5894 mashed5894 marked this pull request as ready for review January 18, 2025 22:40
@mashed5894
Copy link
Contributor Author

d2738de adds code from v9.4 which also includes a warning popup when the program launces if no ffmpeg install is found.

@Computerdores
Copy link
Collaborator

Is there anything else you want to add to this PR? Because otherwise I will move it to pending merge

@mashed5894
Copy link
Contributor Author

Translations, and i also need to either figure out how to get the current config path or remove that line.

@mashed5894
Copy link
Contributor Author

That should be all, as i realized translations are managed by weblate and not normal prs!

Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looking good!
(A nice to have would be being able to click the config path and having it open in the file application, but that could also just be a future PR.)

Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this! I'll add @seakrueger as a co-author to credit him for his contributions brought over from #441.

@CyanVoxel CyanVoxel merged commit 7780289 into TagStudioDev:main Jan 22, 2025
5 checks passed
@mashed5894 mashed5894 deleted the about-section branch January 23, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants