-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translations #662
feat: translations #662
Conversation
…g untranslated stuff
Just a note, I would avoid renaming the keys if possible or else I don't think Weblate will know how to propagate those changes automatically. In f4b30c1 I had to update the keys across all translation files simultaneously before updating on the Weblate side. |
This PR is now ready for review |
@CyanVoxel could you have a look a my responses to the review comments once you have time? |
Everything else is looking great, there's just one last issues I've run into - when my program was translated to German it wouldn't function properly, specifically with the item thumbnails. No files could render thumbnails or be selected and when closing the library I'd get a very long succession of tracebacks:
|
Do you know what you were doing when that happened? Because this doesn't happen for me and the traceback is basically useless (the file in which the error occurs wasn't even modified by this PR) |
Adding a "Blocked" label to remind myself to temporarily close the Weblate translations before pulling this to avoid merge conflicts |
The |
I still can't reproduce the crash though |
Everything seems to be fixed for me now as of cc4b6df, minus the uncommented |
The regression is fixed now - should be good to merge then, right? |
Fixed up a couple things with the en.json file, but other than that I think that's everything! Thank you so much for your work on this! |
Implements Translation using the translation files from weblate. Also modifies
en.json
when necessary.For testing go to
src/qt/translations.py
and either:Translations.change_language("<language of choice>")
at the end of the file,return "???"
in__getitem__
.The first option should leave untranslated strings in Englisch while the second should replace every string that is effected by translations to
???
.Notes:
preview_panel.py
isn't translated completely, mostly due to ongoing refactoring of that file in other placesClose #598.
Close #447.
Close #524.