Rename a filter for consistency. #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An already existing filter on individual items is called `tgmpa_table_data_item`. It would therefore be more logical for this filter on the array of items to be called `tgmpa_table_data_items` instead of `tgmpa_plugin_table_items`. This shouldn't give any issues with "existing implementations" as the filter was only introduced about a week ago.
GaryJones
added a commit
that referenced
this pull request
May 4, 2015
Rename a filter for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An already existing filter on individual items is called
tgmpa_table_data_item. It would therefore be more logical for this filter on the array of items to be calledtgmpa_table_data_itemsinstead oftgmpa_plugin_table_items.This shouldn't give any issues with "existing implementations" as the filter was only introduced about a week ago.