chore(lint): switch from JSHint to ESLint

Fixes mozilla#156
Switch from JSHint to ESLint
Add rules to ESLint
Also have JSHint in parallel
Add inline rules for ignoring complexity

.eslintrc

@@ -0,0 +1,10 @@
+{
+  "extends": "fxa",
+  "env": {
+    "amd": true,
+    "node": true
+  },
+  "rules": {
+    "strict": 0
+  }
+}

Gruntfile.js

@@ -27,8 +27,8 @@ module.exports = function (grunt) {
     ['intern:node', 'intern:native_node']);
 
   grunt.registerTask('lint',
-    'Alias for jshint and jscs tasks',
-    ['jshint', 'jscs']);
+    'Alias for eslint, jshint and jscs tasks',
+    ['eslint', 'jshint', 'jscs']);
 
   grunt.registerTask('default',
     ['build']);

client/.eslintrc

@@ -0,0 +1,10 @@
+{
+  "env": {
+    "amd": true,
+    "browser": true,
+    "node": false
+  },
+  "rules": {
+    "no-console": 0
+  }
+}

client/FxAccountClient.js

@@ -75,6 +75,7 @@ define([
     return credentials.setup(email, password)
       .then(
         function (result) {
+          /*eslint complexity: [2, 9] */
           var endpoint = '/account/create';
           var data = {
             email: result.emailUTF8,

client/lib/hawk.js

@@ -47,7 +47,7 @@ define(['sjcl'], function (sjcl) {
      */
 
     header: function (uri, method, options) {
-
+      /*eslint complexity: [2, 21] */
       var result = {
         field: '',
         artifacts: {}

client/lib/request.js

@@ -38,6 +38,7 @@ define(['./hawk', 'p', './errors'], function (hawk, P, ERRORS) {
    * @return {Promise} A promise that will be fulfilled with JSON `xhr.responseText` of the request
    */
   Request.prototype.send = function request(path, method, credentials, jsonPayload, options) {
+    /*eslint complexity: [2, 8] */
     var deferred = P.defer();
     var xhr = new this.xhr();
     var uri = this.baseUri + path;

package.json

@@ -36,6 +36,7 @@
   },
   "devDependencies": {
     "bower": "~1.3.9",
+    "eslint-config-fxa": "1.2.0",
     "grunt": "~0.4.2",
     "grunt-build-control": "git://github.com/robwierzbowski/grunt-build-control#274952",
     "grunt-bump": "0.0.13",
@@ -48,6 +49,7 @@
     "grunt-contrib-yuidoc": "~0.5.0",
     "grunt-conventional-changelog": "~1.1.0",
     "grunt-copyright": "~0.1.0",
+    "grunt-eslint": "14.0.0",
     "grunt-jscs": "0.7.1",
     "grunt-open": "~0.2.2",
     "http-proxy": "~1.0.2",

tasks/eslint.js

@@ -0,0 +1,16 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+module.exports = function (grunt) {
+  grunt.config('eslint', {
+    options: {
+      eslintrc: '.eslintrc',
+      src: ['Gruntfile.js', 'tasks/*.js', 'config/**/*.js', 'node/**/*.js']
+    },
+    app: {
+      options: {eslintrc: 'client/.eslintrc'},
+      src: ['client/*.js', 'client/lib/**/*']
+    }
+  });
+};