Fix for issue 84 #86
Merged
Fix for issue 84 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it on Linux and Android. It's merged now and I've created the new release. Thank you. :) |
|
My only issue with this fix is I don't always want it to be advertising just because it is disconnected. I may want it disconnected, such as I shut my PC down for the evening, and I don't want my neighbors randomly connecting to it. I prefer rousir's build with which I can remain connected with an isConnected check and retrigger advertising with a startAdvertising, or manual trigger advertising when I want to reconnect |
|
The problem with rousir's build is that it would break backwards-compatibility. Maybe we can add an option to disable automatic advertising. |
Macka323
added a commit
to Macka323/ESP32-BLE-Keyboard
that referenced
this pull request
Apr 23, 2021
|
I think a switch in the startAdvertising function would do the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84
Tested on iOS, Windows, Mac
Please generate a release after merging. 👍🏻