Set ScanResponse to off so the advertising will actually advertise...

[aovestdipaperino]

…the name.
See this line for why.

[T-vK]

Thanks for the PR, before I can accept it, it needs to be tested on Mac OS, Windows, Linux Android and iOS. What operating systems have you tested this with?

[aovestdipaperino]

MacOS, iOS and Android. I might be able to help with Windows and Chrome OS (which should cover Linux?)

[aovestdipaperino]

Also: irrelevant to the topic, but the latest release zip didn't seem to match the code in the repository. For example the BleKeyboard::onConnected(BLEServer *pServer) was missing.

[T-vK]

I don't know about Chrome OS, but it would be nice to have it tested there as well. I will test it on a standard Linux distro next week and if you or someone else confirms it also works on Windows, I'll accpt the PR.
Yeah I should have made a new release after onConnected was added. I'll make a new release when your PR is merged.

[aovestdipaperino]

Awesome. I will do it on Windows, I can borrow a laptop.
One courtesy: I made a mistake with user when I submitted. If you don't mind I will close this one and reopen a new identical one.

[T-vK]

Normally you would just undo your commit and then make a new commit and force push it. This would automatically modify the PR. E.g.

git reset HEAD^
git add .
git commit -m "Set ScanResponse......."
git push --force

but if you find that's too complicated, feel free to make another PR.

[aovestdipaperino]

Done thanks. I didn't realize it was the last commit in this repository as I had a similar problem in another one.

[T-vK]

I did a quick Linux test and it seems to work. When you've verified it works on Windows, I'll merge.

[aovestdipaperino]

All done, looks legit. Thank you, this was smooth.

[T-vK]

Probably yes, but I'm not sure how this has affected iOS/MacOS compatibility. It seems like some of the most recent commits broke compatibility with certain iPhones/iPads and at the same time fix issues for other iPhones/iPads. This kinda makes me wanna drop Apple support completely...