Fixes for Windows #847
Merged
Fixes for Windows #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this reduces dependencies on implementations of GadgetronClientWrapper otherwise exposed.In particular, gadgetron_client.h includes boost::asio, which on Windows includes a lot of Windows files, causing occasional trouble with redefinition of Winsock.h, see SyneRBI#587. We define WIN32_LEAN_AND_MEAN to try to overcome this, but if you include files in the wrong order, you still have this problem. This update therefore makes sure that boost::asio is only used include where it is needed.
one genuine fix, but one cop-out by disabling the warning for float conversions
use sprintf_s and strcpy_s for Visual Studio in headers. They are safer (check buffer overrun) and avoid compiler warnings. Potentially should be used for other compilers as well.
they don't seem to be needed, and we therefore get fewer warnings about them
|
see commit messages for rationale |
evgueni-ovtchinnikov
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587
Also reduces number of warnings during compilation with VS (still far too many)