-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with nesting of share links #1615
Conversation
Test test upload something, then create a share link. Log out and access via share link. Then try to follow items in table to see if the share links nest down |
Tested. Almost all links are working except sequence links. Sequence links are not getting the hashcode |
I tested this again, and sequences worked for me. Can you double check? I opened a private collection with a part that has a sequence. I generated a share link for the collection. I then logged out, and used the share link to reaccess the collection. I then clicked on the part and then clicked on the sequence, and the sequence page opened for me. |
Here is a collection I just made too. The part is from the SBOL Test Suite. If you click, for example, BBa_F2620, any of the component definition in the first table, the sequence link doesn't have the share hashcode. |
I cannot open a collection on your laptop. Can you describe all the steps you did to create the collection and test sharing? |
I sent the part to you through Slack. I just made a new collection, including just this part. Then, clicked share and copied the link into an Chrome incognito window. |
@danielfang97 Please test again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and sequence links are now working.
Closes #1613