Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nesting of share links #1615

Merged
merged 7 commits into from
Feb 21, 2025
Merged

Fix issue with nesting of share links #1615

merged 7 commits into from
Feb 21, 2025

Conversation

cjmyers
Copy link
Collaborator

@cjmyers cjmyers commented Jan 30, 2025

Closes #1613

@cjmyers cjmyers requested a review from danielfang97 January 30, 2025 00:17
@cjmyers
Copy link
Collaborator Author

cjmyers commented Jan 30, 2025

Test test upload something, then create a share link. Log out and access via share link. Then try to follow items in table to see if the share links nest down

@danielfang97
Copy link
Collaborator

Tested. Almost all links are working except sequence links. Sequence links are not getting the hashcode

@cjmyers
Copy link
Collaborator Author

cjmyers commented Feb 7, 2025

I tested this again, and sequences worked for me. Can you double check? I opened a private collection with a part that has a sequence. I generated a share link for the collection. I then logged out, and used the share link to reaccess the collection. I then clicked on the part and then clicked on the sequence, and the sequence page opened for me.

@danielfang97
Copy link
Collaborator

http://localhost:7777/user/dfang97/test8/test8_collection/1/0765265ecf4206d4733635ac585626b4598c4225/share

Here is a collection I just made too. The part is from the SBOL Test Suite. If you click, for example, BBa_F2620, any of the component definition in the first table, the sequence link doesn't have the share hashcode.

@cjmyers
Copy link
Collaborator Author

cjmyers commented Feb 11, 2025

I cannot open a collection on your laptop. Can you describe all the steps you did to create the collection and test sharing?

@danielfang97
Copy link
Collaborator

I sent the part to you through Slack. I just made a new collection, including just this part. Then, clicked share and copied the link into an Chrome incognito window.
In the collection, I clicked BBa_F2620, then opened the components table, clicked on one of the component definitions in the definitions column, then clicked on the sequence in the first table. The sequence here does not have the hashcode for sharing.

@cjmyers
Copy link
Collaborator Author

cjmyers commented Feb 13, 2025

@danielfang97 Please test again

Copy link
Collaborator

@danielfang97 danielfang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and sequence links are now working.

@cjmyers cjmyers merged commit c6b64f4 into master Feb 21, 2025
4 checks passed
@cjmyers cjmyers deleted the fixShareNesting branch February 21, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share link issue
2 participants