Lazy logging #462
Merged
Lazy logging #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I think this PR should also include deleting |
|
Done |
tcmitchell
approved these changes
Mar 6, 2025
| @@ -124,7 +123,7 @@ def _build_extension_object(self, identity: str, sbol_type: str, | |||
| build_type = type_uri | |||
| break | |||
| except KeyError: | |||
| logging.warning(f'No builder found for {type_uri}') | |||
| logging.warning('No builder for %s', type_uri) | |||
There was a problem hiding this comment.
We should maintain the text of the warning message unless there is a good reason to change it.
Suggested change
| logging.warning('No builder for %s', type_uri) | |
| logging.warning('No builder found for %s', type_uri) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#433 f strings replaced with recommended Lazy % style logging