range replaced with enumerate #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcmitchell
reviewed
Mar 3, 2025
sbol3/toplevel.py
Outdated
| new_reference = identity_map[str_item].identity | ||
| for i, item in enumerate(items): | ||
| str_item = str(item) | ||
| if str(item) in identity_map: |
There was a problem hiding this comment.
Suggested change
| if str(item) in identity_map: | |
| if str_item in identity_map: |
tcmitchell
reviewed
Mar 3, 2025
sbol3/toplevel.py
Outdated
| for i, item in enumerate(items): | ||
| str_item = str(item) | ||
| if str(item) in identity_map: | ||
| new_reference = identity_map[str(item)].identity |
There was a problem hiding this comment.
Suggested change
| new_reference = identity_map[str(item)].identity | |
| new_reference = identity_map[str_item].identity |
|
This looks great. I think this PR should also include deleting |
|
Yeah great idea, slipped my mind. Thank you |
|
Done |
tcmitchell
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#433 Simple fix replacing
range(len(items))withenumerate(items)