Improve pylint compatibility - sbol3.provelance #459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
PR for #433
After analyzing the pylint reports and wanted to share my observations:
Wildcard Imports Inflate Warning Counts:
The ~9,000
unused-import
warnings appear to stem from a pattern wherefrom . import *
statements pull in unused modules/classes. For example, inprovenance.py
(line 6), a single wildcard import triggers 247unused-import
warnings, each for an unused item. This suggests that many warnings are redundant and could be resolved by replacing wildcard imports with explicit imports of only necessary classes/functions.Why
provenance.py
?:This PR:
wildcard-import
andunused-import
.Further changes:
too-many-arguments
is also common refactor recommendation. Like in the case below.Please help with these cases.
Thank you for your guidance!
— Harsh
pylint sbol3/provelance.py
Previous score : 0 / 10
Current score : 8.35 / 10