Fix validation failures of jpg/jpeg files #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update of symfony/mime renders the current validator incompatible. This issue is identical to the one from flarum/core's avatar uploader (flarum/framework#2497) and can be fixed in the same way. Tested locally
SychO9
previously requested changes
Dec 22, 2020
|
Great extension thank you. I am not a developer so please excuse my ignorance. How would I apply this fix? Can I just reinstall via composer and the fix will pull through? Or do I manually drop in the new src/CoverValidator.php? |
|
I released this fix in |
|
Perfect, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update of symfony/mime renders the current validator incompatible. This issue is identical to the one from flarum/core's avatar uploader (flarum/framework#2497) and can be fixed in the same way. Confirmed lokally that the fix works.