Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pagination of sources which require pages to be fetched in order #451

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Fix/pagination of sources which require pages to be fetched in order #451

merged 2 commits into from
Nov 11, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Nov 11, 2023

No description provided.

At least e-hentai is not able to handle out of order pagination requests.
E.g. in case the last request was for page 1 and the next one is for page 3, the result will be for page 2, because e-hentai just ignores the request page number and just returns the next page after the last fetched one.
At least e-hentai is not able to handle out of order pagination requests.
The revalidation logic will cause exactly this.
Due to this, the revalidation for these sources is disabled.
To prevent an out of date cache, it gets cleared when routing to the source component
@schroda schroda merged commit a0a52b1 into Suwayomi:master Nov 11, 2023
@schroda schroda deleted the fix/pagination_of_sources_which_require_pages_to_be_fetched_in_order branch November 11, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant