-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert Double Page switch #418
Conversation
Finished the changes. Let me know what you think! |
looks good, just a few things since the setting only effects the double page reader, it should only be shown in case it is selected I think "offset first page" would describe the behaviour better (in code and text shown to the user) not really relevant, but I would leave the "reader type" as the last setting, I think it looks better this way |
I made all the changes. |
nice job improving the double page reader 👍 looks like there is also some issue with viewing a not downloaded/cached chapter with the double page reader, if you're interested in taking a look at it |
I added a toggle that switches which page comes first in double page mode.
Before:

After:

Here's with it off:

Here's with it on:

It is currently a work in progress. Features I want to add are:
This closes the issue I made #416