Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert Double Page switch #418

Merged
merged 14 commits into from
Sep 27, 2023
Merged

Invert Double Page switch #418

merged 14 commits into from
Sep 27, 2023

Conversation

rickymcmuffin
Copy link
Contributor

I added a toggle that switches which page comes first in double page mode.

Before:
beforeWebUI

After:
Screenshot 2023-09-07 112618

Here's with it off:
image

Here's with it on:
image

It is currently a work in progress. Features I want to add are:

  • The toggle hides when not in double page mode.
  • The pages switch instantly when clicking the toggle.

This closes the issue I made #416

@rickymcmuffin rickymcmuffin changed the title Newermain Invert Double Page switch Sep 7, 2023
@rickymcmuffin rickymcmuffin marked this pull request as ready for review September 26, 2023 17:04
@rickymcmuffin
Copy link
Contributor Author

Finished the changes. Let me know what you think!

@schroda
Copy link
Collaborator

schroda commented Sep 26, 2023

looks good, just a few things

since the setting only effects the double page reader, it should only be shown in case it is selected

I think "offset first page" would describe the behaviour better (in code and text shown to the user)
the first time I read "invert double page" I didn't understand what it is supposed to do

not really relevant, but I would leave the "reader type" as the last setting, I think it looks better this way

@rickymcmuffin
Copy link
Contributor Author

I made all the changes.

@schroda
Copy link
Collaborator

schroda commented Sep 27, 2023

nice job improving the double page reader 👍

looks like there is also some issue with viewing a not downloaded/cached chapter with the double page reader, if you're interested in taking a look at it

@schroda schroda merged commit 3155c1d into Suwayomi:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants