Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update dependency react router dom to v6.x #340

Merged
merged 9 commits into from
Jun 4, 2023
Merged

Feature/update dependency react router dom to v6.x #340

merged 9 commits into from
Jun 4, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Jun 4, 2023

No description provided.

schroda added 9 commits June 4, 2023 21:29
 - Route without an element causes a warning message.
 - Routes with non-matching Route causes a warning message.
…and "useLocations" typing

For both functions it's the users fault if they are getting used incorrectly.
It's inconvenient to always have to make sure the params exist (useParam) or to cast the return object to a specific type (useLocation)

 - "useParams": Make generic type non-optional
 - "useLocation": Add generic type
@schroda schroda merged commit 4e8813b into Suwayomi:master Jun 4, 2023
@schroda schroda deleted the feature/update_dependency_react_router_dom_to_v6.x branch June 4, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant